-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor configuration #823
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janboll
force-pushed
the
refactor-config
branch
5 times, most recently
from
November 11, 2024 10:13
4758fcf
to
c088bcb
Compare
janboll
requested review from
bennerv,
geoberle,
weinong,
whober0521,
mbarnes,
SudoBrendan,
jmelis,
jonathan34c,
niontive,
nwnt,
UlrichSchlueter,
jharrington22 and
zgalor
as code owners
November 11, 2024 10:20
janboll
force-pushed
the
refactor-config
branch
from
November 11, 2024 10:24
c088bcb
to
e470f29
Compare
Please rebase pull request. |
janboll
force-pushed
the
refactor-config
branch
from
November 18, 2024 09:28
e470f29
to
21d21dc
Compare
Please rebase pull request. |
janboll
force-pushed
the
refactor-config
branch
2 times, most recently
from
November 18, 2024 13:39
a47f830
to
07c2b64
Compare
geoberle
previously approved these changes
Nov 19, 2024
janboll
force-pushed
the
refactor-config
branch
from
November 19, 2024 08:10
07c2b64
to
37c3116
Compare
geoberle
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Refactor configuration to
Follow up on #820
Jira:
Link to demo recording:
Special notes for your reviewer